Do not attempt to show siblings if there aren't any #3269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a parent manual has been withdrawn and redirected, we don't get the value for `child_section_groups` as the redirect content item doesn't contain this value. Therefore not showing any siblings items at all when this is the case, as we can't be sure what the correct parent actually is for this manual section.
The `siblings` variable has the same name as a method, so renaming the variable to avoid confusion.
beccapearce
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a parent manual has been withdrawn and redirected, we don't get the value for
child_section_groupsas the redirect content item doesn't contain this value.Therefore not showing any siblings items at all when this is the case, as we can't be sure what the correct parent actually is for this manual section.
This also resolves an issue where there are no breadcrumbs given for an item.
Trello card