Minor bug fixes to HMRC manual layout and breadcrumbs #3284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannako
changed the title
KludgeKML
reviewed
Jul 30, 2024
KludgeKML
approved these changes
Jul 30, 2024
Some HMRC manual content items don't contain a description. E.g. https://www.gov.uk/api/content/hmrc-internal-manuals/capital-gains-manual In this case, we should not show the heading "Summary" as the content of the summary is missing.
A bug was introduced in 8128fb2 so that breadcrumbs were no longer being displayed on the page. If breadcrumbs are present in the content item, we should display them. If they're absent, display a back link to the parent manual.
hannako
force-pushed
the
hmrc_manual_breadcrumbs
branch
from
c221f01 to
70f902a
Compare
hannalaakso
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/DwMxfbuf/1145-breadcrumb-issues-in-hmrc-internal-manuals
1. Don't display the "Summary" heading if there's no content below it.
Eg on https://www.gov.uk/hmrc-internal-manuals/capital-gains-manual
Here's a page that has a populated description on live and on the review app to show that there's no visible change.
2. If breadcrumbs are present, display them
Eg debt management and banking manual
Eg capital gains manual
Follow these steps if you are doing a Rails upgrade.