Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve print styles for right-to-left (RTL) content. #3404

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

matthillco
Copy link
Contributor

What

Improvements to components and layouts so that right-to-left (RTL) content renders correctly when printing*. This is part of the work to improve print styles more generally. Trello

Note: This PR depends on alphagov/govuk_publishing_components#4365 and alphagov/collections#3835 and the After screenshots below include those dependecies.

* Although this PR is specifically about print styles, some fixes also apply to the screen rendering due to problems originating in the screen styles.

Why

Some pages are broken for foreign languages that read right to left, with styles not set correctly for the changed direction.

Visual Changes

Publications Page

Before After
image image

News Article

Before After
image image

Speech

Before After
image image

@matthillco matthillco marked this pull request as ready for review January 16, 2025 17:47
Copy link
Contributor

@AshGDS AshGDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@matthillco matthillco merged commit d7c3224 into main Jan 17, 2025
11 checks passed
@matthillco matthillco deleted the rtl-print-styles branch January 17, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants