Show old related links for selected content items #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fofr
suggested changes
May 9, 2017
| <% if MainstreamContentFetcher.with_curated_sidebar.include?(content_item.base_path) %> | ||
| <%= | ||
| render( | ||
| partial: 'govuk_component/relted_items', |
There was a problem hiding this comment.
'govuk_component/relted_items'
Typo here.
There was a problem hiding this comment.
Not sure how your tests were passing.
There was a problem hiding this comment.
well spotted! I've fixed it.
There was a problem hiding this comment.
there is no rendering going on locally, only a mock of the component with the data...
There was a problem hiding this comment.
I think this is where using the correct component CSS selectors would have surfaced the bug in tests.
There was a problem hiding this comment.
Can you try switching to that?
We are in the process of releasing the new navigation for Education content. One item that needs to be solved from a product perspective is how to deal with curated related links. Until that's solved, some content items still need to show the old related links instead of the new navigation for users in the B group of our A/B test. These overrides existed in the `frontend` application. Since `answers` were ported to `government-frontend`, we also need to port the override.
carvil
force-pushed
the
port-mainstream-sidebar-override
branch
from
9d15820 to
f2ef29d
Compare
This change makes sure we find the correct sidebars in tests.
fofr
approved these changes
May 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are in the process of releasing the new navigation for Education
content. One item that needs to be solved from a product perspective is
how to deal with curated related links. Until that's solved, some
content items still need to show the old related links instead of the
new navigation for users in the B group of our A/B test.
These overrides existed in the
frontendapplication. Sinceanswerswere ported to
government-frontend, we also need to port the override.Trello: https://trello.com/c/U6JKZN6s/115-make-sure-we-override-the-related-links-on-some-mainstream-content-that-was-recently-moved-to-government-frontend