Test component guide #452
Merged
Test component guide #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fofr
reviewed
Aug 17, 2017
test/components/all_components.rb
Outdated
| end | ||
| components.each do |component| | ||
| visit component[:href] + '/preview' | ||
| end |
There was a problem hiding this comment.
Could this be:
all(:css, '.component-list a').each do |el|
visit "#{el[:href]}/preview"
endThere was a problem hiding this comment.
I think it suffered from the issue we ran into where the instances can't be visited since they 'no longer exist'
There was a problem hiding this comment.
component_previews = all(:css, '.component-list a').map do |el|
"#{el[:href]}/preview"
end
component_previews.each do |component|
visit component
endThere was a problem hiding this comment.
That's better, I think I was tired when I wrote this because there's also unneeded data in there too. Will update
fofr
reviewed
Aug 24, 2017
test/components/all_components.rb
Outdated
| @@ -0,0 +1,15 @@ | |||
| require 'component_test_helper' | |||
There was a problem hiding this comment.
I think this can be test_helper
This will catch any JavaScript errors on the page, which will be useful when we throw accessibility related errors
Pick up aXe testing
The aXe JS provided by the govuk_publishing_components gem was not available during integration tests, meaning accessibility would not be found locally. Don't depend on precompiled JS assets. We are not currently precompiling javascript before tests run when testing locally. Meaning failing JS will not be detected in integration tests until they reach CI.
fofr
force-pushed
the
test-component-guide
branch
from
2c426ec to
a806be8
Compare
|
Rebased with master and updated gem to pick up aXe tests. Needed to add a806be8 for tests to fail as expected when running locally. |
gpeng
approved these changes
Aug 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prepares government-frontend to be able to pick up throw accessibility errors from the component guide.
Related PR: alphagov/govuk_publishing_components#33