Fix colour contrast in publication headers #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTML publication headers currently don't meet WCAG AA colour contrast ratio for normal text. Changing this from $light-blue to $govuk-blue fixes this.
|
👍 has one of the designers from your team had a looksie? |
|
Showed this to @alextea and @markhurrell, who seemed ok with it. |
fofr
approved these changes
Oct 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTML publication headers currently don't meet WCAG AA colour contrast ratio for normal text. Changing this from $light-blue to $govuk-blue fixes this.
Before:
After:
Previous ratio was 3.72:1, new ratio is 6.68:1 (need to meet 4.5:1)
Live page: https://government-frontend-pr-497.herokuapp.com/government/publications/budget-2016-documents/budget-2016
Review app component guide:
https://government-frontend-pr-497.herokuapp.com/component-guide
Visual regression results:
https://government-frontend-pr-497.surge.sh/gallery.html