Add national applicability to universal navigation variant #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use pattern from static metadata component: https://govuk-static.herokuapp.com/component-guide/metadata * Allow further metadata to be added easily as design is iterated * This allows us to easily add national applicability
* Move content_metadata params into metadata presenter module * Decorate with “Applies to” when National Applicability applies * Add “Applies to” to the beginning of the hash to appear before “From” * Use existing methods for generating “Applies to” from content item * Improve rendering of component when no dates provided
fofr
force-pushed
the
national-applicability-no-nav
branch
from
74e1ae1 to
8dfbd93
Compare
maxgds
reviewed
Nov 15, 2017
| - <a href='/government/organisations/education-funding-agency'>Education Funding Agency</a> | ||
| - <a href='/government/organisations/department-for-work-pensions'>Department for Work and Pensions</a> | ||
| nothing: | ||
| description: | |
There was a problem hiding this comment.
Should this be an example or just a line in the intro to the component? I can see why you'd consider the fail state and test against it but specifically presenting an example seems counter intuitive to me.
There was a problem hiding this comment.
I think it's appropriate to keep to avoid the risk of future regressions.
A few other components in static do this too.
|
Quite an overhaul! Makes sense, though. Just one query around the examples given in the guide but it otherwise looks good. |
maxgds
approved these changes
Nov 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow content metadata to render any metadata types
https://govuk-static.herokuapp.com/component-guide/metadata
Add national applicability to content metadata
Review app component guide:
https://government-frontend-pr-539.herokuapp.com/component-guide/content-metadata