Add fieldset component #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickColley
force-pushed
the
add-fieldset-components
branch
from
2561c17 to
037c518
Compare
NickColley
force-pushed
the
add-fieldset-components
branch
from
037c518 to
e08de38
Compare
|
LGTM, just wondering if we could squash these two commits, as the 2nd one is just overwriting the boilerplate generated in the 1st one? |
|
Can do, I like doing commits for generation scripts, but not precious about it |
NickColley
force-pushed
the
add-fieldset-components
branch
from
e08de38 to
226c32f
Compare
Generate boilerplate for component using bundle exec rails generate govuk_publishing_components:component fieldset Forked from GOV.UK Frontend
NickColley
force-pushed
the
add-fieldset-components
branch
from
226c32f to
2d09da0
Compare
emmabeynon
approved these changes
Dec 4, 2017
|
@NickColley The commit mentioned tests? |
|
@leenagupte I was cleaning up some merge conflicts and I think nuked the tests for this. Reopened here: #563 |
NickColley
added a commit
to alphagov/govuk_publishing_components
that referenced
this pull request
Jan 4, 2018
Moved from government-frontend for use in email-alert-frontend Also renames the namespace to `gem` Originally implemented in alphagov/government-frontend#561
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review app component guide:
https://government-frontend-pr-561.herokuapp.com/component-guide/fieldset
https://trello.com/c/RRbQOeUK/243-create-a-fieldset-component-1