Revert dependabot prs #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems unnecessary to me to revert the capybara and pry-byebug changes, unless you really think that these gems could be responsible for issues in production? They are in groups in the Gemfile, which as I understand it should mean that they are not even loaded by bundler. |
|
@cbaines I don't but the deploy is time critical so I have gone the nuclear approach to maximise my chances of success. As I said these should be reapplied later. |
elenatanasoiu
approved these changes
Feb 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting the PR as we are now seeing a compile failure in production as I need to deploy this in order to remove a webchat instance.
This PR should be reapplied one at a time to determine which change is causing the issue
Component guide for this PR:
https://government-frontend-pr-[THIS PR NUMBER].herokuapp.com/component-guide