Replace publication header with inverse header #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanitabarrett
force-pushed
the
replace-publication-header-with-inverse-header
branch
from
75a19ac to
cbfaad0
Compare
added 2 commits
March 26, 2018 10:04
We created a new inverse header component as part of the work for building new topic pages. This component is a shared component in the govuk_publishing_components gem. As it behaves very similarly to the existing publication header component in government-frontend, it makes sense to try and consolidate the two. This commit therefore replaces uses of the publication header with inverse header, and removes the publication header component.
vanitabarrett
force-pushed
the
replace-publication-header-with-inverse-header
branch
from
cbfaad0 to
780ce8e
Compare
vanitabarrett
deleted the
replace-publication-header-with-inverse-header
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello: https://trello.com/c/0pbli2e8/152-tech-debt-replace-publication-header-component-with-inverse-header-component
We created a new inverse header component as part of the work for building new topic pages. This component is a shared component in the govuk_publishing_components gem. As it behaves very similarly to the existing publication header component in government-frontend, it makes sense to try and consolidate the two.
This PR replaces the publication header with the inverse header.
Before:
After:
https://government-frontend-pr-845.herokuapp.com/government/publications/ln5-0at-jackson-homes-scopwick-ltd-environmental-permit-application-advertisement/ln5-0at-jackson-homes-scopwick-ltd-environmental-permit-application
Component guide for this PR:
https://government-frontend-pr-845.herokuapp.com/component-guide