Always use the non-numbered contents list #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
reviewed
Mar 28, 2018
| <ol | ||
| class="column-half" | ||
| <% if i == 1 %> | ||
| start="<%= content_item.parts_navigation_second_list_start %>" |
There was a problem hiding this comment.
This can also be removed!
There was a problem hiding this comment.
Not anymore, since we're keeping the old style nav for travel advice.
| <% if show_alternate_guide_chapters? %> | ||
| <%= render "components/contents-list", aria_label: navigation_label, contents: content_item.part_link_elements %> | ||
| <% else %> | ||
| <nav role="navigation" class="grid-row part-navigation" aria-label="<%= navigation_label %>" data-module="track-click"> |
There was a problem hiding this comment.
Are there any styles that can be removed?
There was a problem hiding this comment.
Not anymore, since we're keeping the old style nav for travel advice.
This removes the GuideChapterNav A/B test. We've tested this and we'll keep the B version. Except for travel advice, which keeps its navigation. https://trello.com/c/ndUiAA1y
tijmenb
force-pushed
the
use-b-variant-of-component
branch
from
741d5d5 to
b395d05
Compare
sihugh
approved these changes
Mar 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
GuideChapterNavA/B test. We've tested this and we'll keep the B version.https://trello.com/c/ndUiAA1y