This repository has been archived by the owner on Nov 2, 2021. It is now read-only.
Update heading levels on Your Information page #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an accessibility issue highlighted in the DAC report, wherein the heading structure on the "Your information" consent page is flat, despite hierarchical relationships being present. Updating the radio groups' headings to h3 (previously h2) addresses this issue.
danacotoran
force-pushed
the
a11y-fix-headings
branch
from
5be404d to
b27c521
Compare
andysellick
approved these changes
Mar 3, 2021
|
I assume we've already bumped to the version of the gem with this feature in it? |
@andysellick Indeed we have #718 Thanks for approving 🙏🏼 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the radio groups' headings to
h3(previouslyh2) on the "Your information" page.This fixes an accessibility issue highlighted in the DAC report, wherein the heading structure on the "Your information" consent page is flat, despite hierarchical relationships being present.
Depends on this PR which adds the option to pass a custom heading level to the radio group alphagov/govuk_publishing_components#1951MERGEDhttps://trello.com/c/lNkwruEi/647-fix-accessibility-issues-raised-by-dac (this corresponds to Headings (A) page 21 on the checklist)