Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run aXe on the GOV.UK Design System #620

Closed
NickColley opened this issue Nov 2, 2018 · 2 comments · Fixed by #784
Closed

Run aXe on the GOV.UK Design System #620

NickColley opened this issue Nov 2, 2018 · 2 comments · Fixed by #784
Assignees
@hannalaakso
Labels
accessibility

Comments

@NickColley
Copy link
Contributor

NickColley commented Nov 2, 2018 •
edited
Loading

When we last got the Design System website audited, we found a lot of the issues would have been caught with running aXe on the pages.

I'm not sure we wrote up an issue for this and I think it's important to do automating testing where possible.

Note: This is the design system website itself, not the GOV.UK Frontend components.
@Jagordon
Copy link

Jagordon commented Nov 8, 2018

Found a 'critical' issue on the Radio buttons with conditional reveal component

Fix the following:
ARIA attribute is not allowed: aria-expanded="false"

@NickColley
Copy link
Contributor Author

NickColley commented Nov 8, 2018 •
edited
Loading

@Jagordon this is a known issue: alphagov/govuk-frontend#979

It's difficult because we're intentionally using aria attributes on an element that technically should not support it but it does improve what's announced to screenreaders.

@timpaul timpaul mentioned this issue Jan 9, 2019
Closed
31 tasks
@NickColley NickColley assigned NickColley and unassigned NickColley Jan 17, 2019
@aliuk2012 aliuk2012 self-assigned this Jan 21, 2019
@aliuk2012 aliuk2012 mentioned this issue Feb 4, 2019
Merged
@hannalaakso hannalaakso assigned hannalaakso and unassigned NickColley Mar 1, 2019
hannalaakso added a commit that referenced this issue Mar 1, 2019
@hannalaakso
Fix bug with invalid example IDs
3522fc1 
This reverts a hotfix #809
that removed the changes in favour of a proper fix for
#620

Generating example IDs from example titles can be brittle if there
are unexpected characters in titles. Use the IDs and
fall back to default ones and uses the solution from #620 to fix
duplicate IDs
@hannalaakso hannalaakso mentioned this issue Mar 1, 2019
Merged
hannalaakso added a commit that referenced this issue Mar 4, 2019
@hannalaakso @NickColley
Fix bug with invalid example IDs
60d73aa 
This reverts a hotfix #809
that removed the changes in favour of a proper fix for
#620

Generating example IDs from example titles can be brittle if there
are unexpected characters in titles. Use slugger for more robust converting of
exampleTitle to exampleId. This also uses the solution from #620 to fix
duplicate IDs by adding an extra parameter "titleSuffix" to examples if
necessary.

Co-authored-by: Nick Colley <nick.colley@digital.cabinet-office.gov.uk>
@andrewscrivener andrewscrivener mentioned this issue May 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hannalaakso hannalaakso

Labels
accessibility
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds simple aXe testing to the Design System alphagov/govuk-design-system
5 participants
@NickColley @aliuk2012 @hannalaakso @Jagordon @kellylee-gds