Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guidance for the additional colours for the Tag component #1141

Merged
merged 3 commits into from
Mar 6, 2020

Conversation

adamsilver
Copy link
Contributor

@adamsilver adamsilver commented Jan 27, 2020

First stab at guidance for the additional Tag colours as explained here:
alphagov/govuk-frontend#1711

@adamsilver adamsilver changed the title Added guidance for the additional colours for the Tag component Guidance for the additional colours for the Tag component Jan 27, 2020
@govuk-design-system-ci
Copy link
Collaborator

govuk-design-system-ci commented Jan 27, 2020

You can preview this change here:

Built with commit 0216af3

https://deploy-preview-1141--govuk-design-system-preview.netlify.com

@NickColley
Copy link
Contributor

🌈 are you missing the --grey modifier you're proposing?

@StephenGill
Copy link
Contributor

Hi - looks great, but would be good to include a little more detail in the guidance.

I've drafted some here: https://docs.google.com/document/d/186_znVV07PQg44GOkJ7tbyTwY3JLgXuYJ5K7CtFOJBE/edit

@adamsilver @timpaul @m-green could you have a look and let me know what you think?

@adamsilver
Copy link
Contributor Author

@StephenGill I've made comments and suggestions on the guidance. Thanks a lot for putting this together.

@StephenGill
Copy link
Contributor

Thanks @adamsilver. I've had a go at re-drafting it - could you have a look?

https://docs.google.com/document/d/186_znVV07PQg44GOkJ7tbyTwY3JLgXuYJ5K7CtFOJBE/edit

@adamsilver
Copy link
Contributor Author

Thanks @StephenGill. Looks fab. I spotted a typo and made one suggestion. Feel free to reject it though—no biggie.

@StephenGill
Copy link
Contributor

Thanks @adamsilver - do you want to update the PR with the additional guidance, or is there an easier way to do it?

@adamsilver
Copy link
Contributor Author

@StephenGill I'll do it now!

@simonwhatley
Copy link
Contributor

@adamsilver it is worth highlighting your tag examples are just that, examples. The words used in the tags should be defined by the service team based on user needs.

@adamsilver
Copy link
Contributor Author

@whatterz we don't point out examples are examples elsewhere in the design system (to my knowledge) so I'd be reluctant to do that just for the Tag component.

But, if the examples are confusing maybe we can do something about that. For example, make the examples better, or split up the examples into separate example boxes with descriptions for suggested use.

I guess it would be good to understand exactly what's confusing and why.

@kellylee-gds kellylee-gds linked an issue Feb 20, 2020 that may be closed by this pull request
5 tasks
@adamsilver
Copy link
Contributor Author

@timpaul @StephenGill I've changed the guidance based on feedback from the working group. Let me know what you think.

@StephenGill
Copy link
Contributor

Thanks for this.

When I re-read it, it seemed a little abstract (my fault - it comes from the draft I did).

I've done a bit of a re-write and restructure so it addresses concrete use cases a little more directly. But hopefully I've kept the substance of what you agreed with the working group.

See what you think @adamsilver - if you're happy I'll push the changes: https://docs.google.com/document/d/1-SThdCRmgvAPBNSngoZAa_6wEz9ZDVT2vMYV9lLX_Xg/edit

@adamsilver
Copy link
Contributor Author

@StephenGill really like the restructure! I've added a couple comments/suggestions.

@StephenGill
Copy link
Contributor

Hi @adamsilver - are you happy with this version? If you are, I'll ask one of the team to review it

@adamsilver
Copy link
Contributor Author

@StephenGill the preview isn't working so I can't check.

@StephenGill
Copy link
Contributor

Sorry - probably my fault. I'll ask someone to look into it.

Copy link
Contributor

@36degrees 36degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is dependant on a release of GOV.UK Frontend with the new tag modifiers – once that's done, the changes to package.json should be reverted. Feel free to dismiss this review once that's happened.

@adamsilver
Copy link
Contributor Author

@StephenGill I've removed the note about starting with solid colours as per our chat on the Google doc.

Can we add the existing example at the top back to this? I think it's useful to include it as a way to confirm I'm looking at the right component.

@StephenGill
Copy link
Contributor

Thanks Adam -

@timpaul and I talked about the example. Because it shows the tag from the phase banner - which is quite a long way removed from the typical use case for tags - we thought it best to remove it.

@36degrees 36degrees force-pushed the add-tag-styles branch 2 times, most recently from 4abfd0b to 5d0d8b4 Compare March 6, 2020 14:41
adamsilver and others added 3 commits March 6, 2020 14:45
- Add example for multiple tags with grey and default blue
- Add guidance: starting with as few categories as possible
- Add example with just a few colours
- Add guidance: avoid using mix of tag styles
- Add guidance: same word same colour
- Add guidance: don't make tags clickable
@36degrees 36degrees merged commit 5709a74 into alphagov:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add coloured tags to tag component
6 participants