Add guidance for button groups #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36degrees
force-pushed
the
button-groups
branch
from
59e7772 to
a4f17f3
Compare
36degrees
commented
Jan 26, 2021
| @@ -59,10 +59,6 @@ Pages with too many calls to action make it hard for users to know what to do ne | |||
|
|
|||
| {{ example({group: "components", item: "button", example: "secondary", html: true, nunjucks: true, open: false}) }} | |||
|
|
|||
| You can use secondary buttons in combination with default buttons. | |||
There was a problem hiding this comment.
I ended up moving this because it felt like the example of two buttons should really use a button group, but it seemed strange to use it before it was introduced.
If we think it's important to make this explicit at the point we're talking about secondary buttons we could bring it back, but I think we'd end up including the same example in both places?
|
You can preview this change here: Built with commit d8df89a https://deploy-preview-1472--govuk-design-system-preview.netlify.app |
|
Really great to see this getting added 👍 |
calvin-lau-sig7
approved these changes
Jan 29, 2021
36degrees
force-pushed
the
button-groups
branch
from
4491971 to
d8df89a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add guidance about button groups to the button component guidance.
Includes two examples:
👉🏻 View preview
Closes #1471