Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify use of conditional reveals for questions only (draft) #1573

Merged
merged 2 commits into from
Jun 30, 2021

Conversation

calvin-lau-sig7
Copy link
Contributor

@calvin-lau-sig7 calvin-lau-sig7 commented Mar 17, 2021

Update guidance to clarify that conditional reveals should only be used for questions.
Includes latest conclusions from team to help service teams decide when to use them.

Right now, these edits only cover the 'Radio' component. Once content is approved, I will add a commit in this PR to make similar edits to the 'Checkbox' component.

@govuk-design-system-ci
Copy link
Collaborator

govuk-design-system-ci commented Mar 17, 2021

✔️ You can preview this change here:

🔨 Explore the source changes: 3f21430

🔍 Inspect the deploy log: https://app.netlify.com/sites/govuk-design-system-preview/deploys/60dc8de8917a50000719c256

😎 Browse the preview: https://deploy-preview-1573--govuk-design-system-preview.netlify.app

src/components/radios/index.md.njk Outdated Show resolved Hide resolved
src/components/radios/index.md.njk Outdated Show resolved Hide resolved
@calvin-lau-sig7

This comment has been minimized.

@calvin-lau-sig7 calvin-lau-sig7 force-pushed the calvin-lau-sig7-cond-reveal branch from b90c724 to d2b23b2 Compare March 18, 2021 16:43
@calvin-lau-sig7

This comment has been minimized.

@calvin-lau-sig7
Copy link
Contributor Author

Few changes to get this update released together with a backlog statement (draft) about our research so far.

We will write a blog post in the future which will give more nuanced guidance on how acceptable it is to use conditional reveals.

Discarded 13 April edits, added links to the statement with a call-to-action for users to share their research with us.

Copy link
Contributor

@EoinShaughnessy EoinShaughnessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@calvin-lau-sig7 This is looking really good!

@EoinShaughnessy EoinShaughnessy force-pushed the calvin-lau-sig7-cond-reveal branch from 6f36b73 to 4f0a55f Compare June 14, 2021 09:47
@EoinShaughnessy EoinShaughnessy self-assigned this Jun 15, 2021
@EoinShaughnessy EoinShaughnessy removed their assignment Jun 15, 2021
@calvin-lau-sig7 calvin-lau-sig7 merged commit 8193f86 into main Jun 30, 2021
@calvin-lau-sig7 calvin-lau-sig7 deleted the calvin-lau-sig7-cond-reveal branch June 30, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tell users not to use conditional reveals to reveal text (for example contextual help)
6 participants