-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a summary list example where only some rows have actions #1990
Conversation
✔️ You can preview this change here: 🔨 Explore the source changes: a4baf9f 🔍 Inspect the deploy log: https://app.netlify.com/sites/govuk-design-system-preview/deploys/61bb0704dd89fa000884439f 😎 Browse the preview: https://deploy-preview-1990--govuk-design-system-preview.netlify.app |
Okay, guidance looks to me thanks all! This is probably ready to move to 'Blocked' pending release of 4.0. |
f3acf26
to
1f8c648
Compare
Rebased on top of the other guidance changes which I've split out into #1997 – that PR should be merged first at which point the base for this PR will update to |
1f8c648
to
bb711a3
Compare
Co-authored-by: EoinShaughnessy <72507742+EoinShaughnessy@users.noreply.github.com>
bb711a3
to
a4baf9f
Compare
Hi @36degrees , is this not available on Im using a "mixed actions" summary list macro and it doesnt seem to be adding the
|
@NikhilNanjappa this change was made in v4.0.0, so should work just fine in v4.1.0. Can you confirm what HTML is being outputted by the macro? |
Hi @36degrees - this is the rendered HTML
PS: I can see the changes you made within the |
Can I just check that you're definitely using the Nunjucks macros included in the GOV.UK Frontend package? You haven't got another version of the |
We are using GOV.UK CASA framework and importing summary list as so:
I just checked their source code and they seem to using govuk-frontend |
Ahah, that would do it! 🙂 It looks like the latest version of GOV.UK CASA might support the latest version of GOV.UK Frontend, but you would need to upgrade to the latest version of GOV.UK CASA in your application. If you're currently importing the CSS and JavaScript separately to GOV.UK CASA, make sure that you're using the same version of GOV.UK Frontend for the CSS, JavaScript and the Nunjucks macros and it should still display correctly. Before v4.0.0 the summary list outputted an empty span ( |
Unfortunately, I dont think we can upgrade just the govuk-frontend version without upgrading the CASA (which is a much bigger change and probably wouldnt be doing it). So I guess we have to be ok with this a11y issue then
Do you know if this can be done ? |
The guidance will not match the HTML in the example until updated to GOV.UK Frontend v4.0 with the changes from alphagov/govuk-frontend#2323. Do not merge until after the Design System has been updated to 4.0.
The example also takes into account changes to the other existing examples made in #1989, which has not yet been merged.
Closes #1948.