Fix colour swatch styles for IE8 #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default static breakpoints is set to desktop and those media queries get rasterized. For colour swatches we have a custom breakpoint that is heigher than desktop so IE8 never gets those styles. To fix, we check if $govuk-is-ie8 == true and if true we set the custom breakpoint to match desktop.
|
You can preview this change here: Built with commit a841402 https://deploy-preview-276--govuk-design-system-preview.netlify.com |
|
Since Jani is on Holiday, and this is broken in production, I'll merge. |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default static breakpoints is set to desktop and those media queries get rasterised.
For colour swatches we have a custom breakpoint that is higher than desktop so IE8 never gets those styles.
To fix, we check if
$govuk-is-ie8 == trueand if true we set the custom breakpoint to match desktop.Before
After
Also fixes: #126