Preview v5: Configure ESLint checks for ES2015 #2959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify site configuration. |
colinrotherham
changed the title
colinrotherham
force-pushed
the
v5-modules
branch
from
d434a21
to
a17c27f
Compare
colinrotherham
force-pushed
the
v5-eslint
branch
from
268d1da
to
8818b19
Compare
colinrotherham
changed the title
36degrees
reviewed
Jul 26, 2023
There was a problem hiding this comment.
Code changes look good to me.
There are three commits that describe removing a rule. But what they're doing is removing the config that disabled the rule, so we're actually re-enabling the rule, not removing it.
For clarity I'd suggest tweaking the commit message to make this clearer. I think the simplest change would just to replace 'Remove' with 'Re-enable'?
colinrotherham
force-pushed
the
v5-eslint
branch
from
8818b19
to
3d35695
Compare
Makes perfect sense to me. Done |
36degrees
approved these changes
Jul 26, 2023
colinrotherham
force-pushed
the
v5-modules
branch
from
a17c27f
to
ceef53a
Compare
colinrotherham
force-pushed
the
v5-eslint
branch
from
3d35695
to
03494ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.