Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview v5: Follow GOV.UK Frontend coding standards #2961

Merged
merged 10 commits into from
Aug 1, 2023
Merged

Preview v5: Follow GOV.UK Frontend coding standards #2961

merged 10 commits into from
Aug 1, 2023

Commits on Aug 1, 2023

  1. Add TypeScript compiler config

    @colinrotherham
    colinrotherham committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    c913dba View commit details
    Browse the repository at this point in the history

  2. Fix compiler “Property 'toGMTString' does not exist on type 'Date'"

    @colinrotherham
    colinrotherham committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    cbf4329 View commit details
    Browse the repository at this point in the history

  3. Fix compiler “Property does not exist on type 'Window & typeof global… 

    …This'"
    @colinrotherham
    colinrotherham committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    9f48f6a View commit details
    Browse the repository at this point in the history

  4. Fix compiler “Property 'classList' does not exist on type 'ParentNode'"

    @colinrotherham
    colinrotherham committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    3f05cf5 View commit details
    Browse the repository at this point in the history

  5. Fix compiler “Argument of type 'boolean' is not assignable to paramet… 

    …er of type 'string'"
    @colinrotherham
    colinrotherham committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    cf558ac View commit details
    Browse the repository at this point in the history

  6. Fix compiler “Property 'className' does not exist on type 'ParentNode'"

    @colinrotherham
    colinrotherham committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    ed71819 View commit details
    Browse the repository at this point in the history

  7. Follow GOV.UK Frontend coding standards for element checks

    @colinrotherham
    colinrotherham committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    3f2b195 View commit details
    Browse the repository at this point in the history

  8. Remove init method from all components

    @colinrotherham
    colinrotherham committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    482ec98 View commit details
    Browse the repository at this point in the history

  9. Remove init() method from initAll function and component example 

    Because we're not storing the object we create using `new`, we're getting a `no-new` failure from eslint.
    @colinrotherham
    colinrotherham committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    7a42845 View commit details
    Browse the repository at this point in the history

  10. Disable type checking for Google Analytics script

    @colinrotherham
    colinrotherham committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    25c911c View commit details
    Browse the repository at this point in the history