Link "Complete multiple tasks" research to task list component #3321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ You can preview this change here:Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@stevenjmesser opps - only just spotted that I somehow lost the research section changes when updating the pattern guidance... 🤦 |
The "Research on this pattern" needs to be updated following the design changes.
frankieroberto
force-pushed
the
update-research-on-task-list-component
branch
from
2de2a51
to
963d914
Compare
Co-authored-by: Colin Rotherham <work@colinr.com>
Co-authored-by: Colin Rotherham <work@colinr.com>
colinrotherham
changed the title
colinrotherham
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Thanks @frankieroberto
Looks good to me so I'm going to approve this, but we'll get another reviewer to double check the old content to make sure we're not losing anything important
(Like the "Services using this pattern" content)
|
@colinrotherham thanks! I wasn’t sure if that list was still needed as the pattern is in such widespread use nowadays. Happy to keep it if it is though! |
colinrotherham
pushed a commit
that referenced
this pull request
Nov 30, 2023
…mponent Link "Complete multiple tasks" research to task list component
colinrotherham
pushed a commit
that referenced
this pull request
Dec 4, 2023
…mponent Link "Complete multiple tasks" research to task list component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like we forgot to update the research section on the new task list pattern page (as we added the research to the new component page instead).
This updates the content.