Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fixed layout, introduce back to top component #687

Merged
merged 3 commits into from
Jan 24, 2019
Merged

Remove fixed layout, introduce back to top component #687

merged 3 commits into from
Jan 24, 2019

Commits on Jan 24, 2019

  1. Remove fixed layout 

    In a previous accessibility audit we had reports of issues with the sticky and independently scrollable parts of our original design.

We also need to meet the new guidance in WCAG 2.1 which means that the design system reflows well when zoomed: https://www.w3.org/TR/WCAG21/#reflow

This change turns the design system into a static layout with a maximum width, which means there is more vertical space for reading, and reflows better without causing obstructions.

Additionally this change makes the design system less 'special' and more like the services that our users build. It also allows us to present the examples in the design system (For example, a component) at a width which is closer to how they will actually be used in a service.

We have created a new back to top component that will return you to the navigation, since some of our pages are long and no longer have the navigation available as you scroll.
    @NickColley
    NickColley committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    ecdf7a3 View commit details
    Browse the repository at this point in the history

  2. Add back to top component

    @NickColley
    NickColley committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    8d2bc0f View commit details
    Browse the repository at this point in the history

  3. Add tests for back to top component

    @NickColley
    NickColley committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    2c6d774 View commit details
    Browse the repository at this point in the history