Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds simple aXe testing to the Design System #784

Merged
merged 6 commits into from
Feb 26, 2019
Merged

Adds simple aXe testing to the Design System #784

merged 6 commits into from
Feb 26, 2019

Commits on Feb 25, 2019

  1. Adds axe-puppeteer for accessiblity testing

    @aliuk2012 @NickColley
    aliuk2012 authored and NickColley committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    e8d6008 View commit details
    Browse the repository at this point in the history

  2. Add accessibility automated tests to templates 

    Instead of testing all the pages in the service, it was decided that it
would be best to check page templates instead of specific components which
should be tested in GOV.UK Frontend.

1. Home page - layout template ✅
2. Component page - layout-pane template ✅
3. Patterns - Gender and Sex page - layout-pane template ✅
4. Cookie page - layout-single-page-prose template ✅
5. Get in touch Page - layout-single-page template ✅
6. Sitemap page - layout-sitemap template ✅
    @aliuk2012 @NickColley
    aliuk2012 authored and NickColley committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    fac2ba9 View commit details
    Browse the repository at this point in the history

  3. Fixes accessiblity issue with missing heading level in an example.

    @aliuk2012 @NickColley
    aliuk2012 authored and NickColley committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    28c2718 View commit details
    Browse the repository at this point in the history

  4. Ensure back to top component anchors to top of page

    @NickColley
    NickColley committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    853e81b View commit details
    Browse the repository at this point in the history

  5. Fixes "Element's title attribute is not unique" issue

    @aliuk2012 @NickColley
    aliuk2012 authored and NickColley committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    3c09165 View commit details
    Browse the repository at this point in the history

  6. Replace overriden ID with titleSuffix 

    Since we're now using the title to generate the ID, add a suffix
the title and avoid having to set a new ID manually.
    @NickColley
    NickColley committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    5d28805 View commit details
    Browse the repository at this point in the history