Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guidance for secondary and warning buttons #865

Merged
merged 1 commit into from
Apr 25, 2019
Merged

Conversation

amyhupe
Copy link
Contributor

@amyhupe amyhupe commented Apr 25, 2019

This pull request makes the following additions to the button component page:

  • examples and guidance for new button styles—secondary buttons, warning buttons
  • a default button example and guidance

👉 https://deploy-preview-865--govuk-design-system-preview.netlify.com/components/button/

@govuk-design-system-ci
Copy link
Collaborator

govuk-design-system-ci commented Apr 25, 2019

You can preview this change here:

Built with commit 68a6c38

https://deploy-preview-865--govuk-design-system-preview.netlify.com

@aliuk2012 aliuk2012 force-pushed the alt_buttons_demo branch 2 times, most recently from fffee32 to ff0e025 Compare April 25, 2019 13:39
This makes the following additions to the button component page:

- examples and guidance for new button styles—secondary buttons, warning buttons
- a default button example and guidance

Co-authored-by: Tim Paul <contact@timpaul.co.uk>
Co-authored-by: amyhupe <amy.hupe@digital.cabinet-office.gov.uk>
@36degrees 36degrees changed the title Alt buttons demo Add guidance for secondary and warning buttons Apr 25, 2019
Copy link
Contributor

@aliuk2012 aliuk2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from tech POV 👏

@aliuk2012 aliuk2012 merged commit d6ac9f9 into master Apr 25, 2019
@aliuk2012 aliuk2012 deleted the alt_buttons_demo branch April 25, 2019 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants