Improve ES module and alternative format documentation #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for govuk-frontend-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
colinrotherham
force-pushed
the
javascript-flavours
branch
from
33bde4a to
fc4b6e8
Compare
| <script type="module" src="<YOUR-JAVASCRIPTS-FOLDER>/app-bundle.min.js"></script> | ||
| ``` | ||
|
|
||
| We encourage the use of ECMAScript (ES) modules but you should check your bundler does not unnecessarily downgrade modern JavaScript for unsupported browsers. |
There was a problem hiding this comment.
Suggested change
| We encourage the use of ECMAScript (ES) modules but you should check your bundler does not unnecessarily downgrade modern JavaScript for unsupported browsers. | |
| We encourage the use of ECMAScript (ES) modules, but you should check your bundler does not unnecessarily downgrade modern JavaScript for unsupported browsers. |
colinrotherham
changed the title
colinrotherham
force-pushed
the
javascript-flavours
branch
from
fc4b6e8 to
2e4b85e
Compare
claireashworth
approved these changes
Dec 8, 2023
claireashworth
approved these changes
Dec 8, 2023
This was referenced Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.