Add section about 'Building configurable components' #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romaricpascal
added
documentation
✅ Deploy Preview for govuk-frontend-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
romaricpascal
force-pushed
the
add-building-configurable-components
branch
from
cf41d8d to
5ee8543
Compare
romaricpascal
commented
Nov 19, 2024
| @@ -253,6 +253,189 @@ createAll(ProjectComponent, undefined, { | |||
| }) | |||
| ``` | |||
|
|
|||
| ## Building configurable components | |||
| The component you’re building may need some configuration to get the information it needs to: | |||
There was a problem hiding this comment.
nitpick The 'to:' ends up all alone on its own line even on wide screen. Admitedly that's something that's going to happen at other screen sizes, but should we fix that when the content container is at its widest?
There was a problem hiding this comment.
Don't think this should block updating. We can finesse if needed!
Adds the [content drafted ahead of the release (internal link)](https://docs.google.com/document/d/1Ptivt7MxnJeUoEv3Tm42iB-MkMuuWd--mhKX1B52CPQ/edit\?tab\=t.0)
romaricpascal
force-pushed
the
add-building-configurable-components
branch
from
5ee8543 to
b240387
Compare
domoscargin
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Only to be merged as part of the 5.8.0 release
Adds the content drafted ahead of the release (internal link) to the 'Building your JavaScript components' page (preview).
I went through the code blocks paying attention to smart quotes and indentation, but it's possible I missed some so please keep an eye for those during the review.
Fixes #486