Throw errors if section heading or button missing

alphagov · Oct 19, 2023 · 0bc19c0 · 0bc19c0
1 parent 48d8ff3
commit 0bc19c0
Show file tree

Hide file tree

Showing 2 changed files with 46 additions and 2 deletions.
diff --git a/packages/govuk-frontend/src/govuk/components/accordion/accordion.mjs b/packages/govuk-frontend/src/govuk/components/accordion/accordion.mjs
@@ -237,8 +237,18 @@ export class Accordion extends GOVUKFrontendComponent {
     const $heading = $header.querySelector(`.${this.sectionHeadingClass}`)
     const $summary = $header.querySelector(`.${this.sectionSummaryClass}`)
 
-    if (!$span || !$heading) {
-      return
+    if (!$heading) {
+      throw new ElementError({
+        componentName: 'Accordion',
+        identifier: `Section heading (\`.${this.sectionHeadingClass}\`)`
+      })
+    }
+
+    if (!$span) {
+      throw new ElementError({
+        componentName: 'Accordion',
+        identifier: `Section button (\`.${this.sectionButtonClass}\`)`
+      })
     }
 
     // Create a button element that will replace the

diff --git a/packages/govuk-frontend/src/govuk/components/accordion/accordion.puppeteer.test.js b/packages/govuk-frontend/src/govuk/components/accordion/accordion.puppeteer.test.js
@@ -798,6 +798,40 @@ describe('/components/accordion', () => {
               'Accordion: Section headers (`.govuk-accordion__section-header`) not found'
           })
         })
+
+        it('throws when any section heading is missing', async () => {
+          await expect(
+            renderAndInitialise(page, 'accordion', examples.default, {
+              beforeInitialisation($module, { selector }) {
+                $module.querySelector(selector).remove()
+              },
+              context: {
+                selector: '.govuk-accordion__section-heading'
+              }
+            })
+          ).rejects.toEqual({
+            name: 'ElementError',
+            message:
+              'Accordion: Section heading (`.govuk-accordion__section-heading`) not found'
+          })
+        })
+
+        it('throws when any section button span is missing', async () => {
+          await expect(
+            renderAndInitialise(page, 'accordion', examples.default, {
+              beforeInitialisation($module, { selector }) {
+                $module.querySelector(selector).remove()
+              },
+              context: {
+                selector: '.govuk-accordion__section-button'
+              }
+            })
+          ).rejects.toEqual({
+            name: 'ElementError',
+            message:
+              'Accordion: Section button (`.govuk-accordion__section-button`) not found'
+          })
+        })
       })
     })
   })