Skip to content

Commit

Permalink
Remove unneeded role=button from semantic button
Browse files Browse the repository at this point in the history
Since the HTML5 button element has the role of button already setting the role attribute to button is not necessary.
  • Loading branch information
NickColley committed Sep 24, 2019
1 parent 0b4d4d3 commit 5ff0009
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/govuk/components/header/template.njk
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
</a>
{% endif %}
{% if params.navigation %}
<button type="button" role="button" class="govuk-header__menu-button govuk-js-header-toggle" aria-controls="navigation" aria-label="Show or hide Top Level Navigation">Menu</button>
<button type="button" class="govuk-header__menu-button govuk-js-header-toggle" aria-controls="navigation" aria-label="Show or hide Top Level Navigation">Menu</button>
<nav>
<ul id="navigation" class="govuk-header__navigation {{ params.navigationClasses if params.navigationClasses }}" aria-label="Top Level Navigation">
{% for item in params.navigation %}
Expand Down

0 comments on commit 5ff0009

Please sign in to comment.