Move header tag outside of header component

alphagov · Apr 25, 2024 · 996e8d0 · 996e8d0
1 parent f977d7e
commit 996e8d0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/govuk-frontend/src/govuk/components/header/template.njk b/packages/govuk-frontend/src/govuk/components/header/template.njk
@@ -34,7 +34,7 @@
 </svg>
 {% endset -%}
 
-<header class="govuk-header {%- if params.classes %} {{ params.classes }}{% endif %}" data-module="govuk-header"
+<div class="govuk-header {%- if params.classes %} {{ params.classes }}{% endif %}" data-module="govuk-header"
   {{- govukAttributes(params.attributes) }}>
   <div class="govuk-header__container {{ params.containerClasses | default("govuk-width-container", true) }}">
     <div class="govuk-header__logo">
@@ -93,4 +93,4 @@
     </div>
   {% endif %}
   </div>
-</header>
+</div>
diff --git a/packages/govuk-frontend/src/govuk/template.njk b/packages/govuk-frontend/src/govuk/template.njk
@@ -36,9 +36,11 @@
       }) }}
     {% endblock %}
 
+    <header>
     {% block header %}
       {{ govukHeader({}) }}
     {% endblock %}
+    </header>
 
     {% block main %}
       <div class="govuk-width-container {%- if containerClasses %} {{ containerClasses }}{% endif %}">