Skip to content

Commit

Permalink
Better explain Babel config browsersListEnv
Browse files Browse the repository at this point in the history
  • Loading branch information
colinrotherham committed Jul 14, 2023
1 parent 7e412fe commit bb9e80f
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 12 deletions.
14 changes: 8 additions & 6 deletions docs/examples/webpack/babel.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,11 @@
* @type {import('@babel/core').ConfigFunction}
*/
module.exports = function (api) {
const browserslistEnv = !api.env('test')
? 'javascripts'
: 'node'
const isBrowser = !api.env('test')

// Apply Browserslist environment for supported targets
// https://github.com/browserslist/browserslist#configuring-for-different-environments
const browserslistEnv = isBrowser ? 'javascripts' : 'node'

return {
presets: [
Expand All @@ -17,10 +19,10 @@ module.exports = function (api) {
bugfixes: true,

// Apply smaller "loose" transforms for browsers
loose: browserslistEnv === 'javascripts',
loose: isBrowser,

// Transform ES modules for Node.js
modules: browserslistEnv === 'node' ? 'auto' : false
// Skip ES module transforms for browsers
modules: isBrowser ? false : 'auto'
}]
]
}
Expand Down
14 changes: 8 additions & 6 deletions packages/govuk-frontend/babel.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,11 @@
* @type {import('@babel/core').ConfigFunction}
*/
module.exports = function (api) {
const browserslistEnv = !api.env('test')
? 'javascripts'
: 'node'
const isBrowser = !api.env('test')

// Apply Browserslist environment for supported targets
// https://github.com/browserslist/browserslist#configuring-for-different-environments
const browserslistEnv = isBrowser ? 'javascripts' : 'node'

return {
presets: [
Expand All @@ -17,10 +19,10 @@ module.exports = function (api) {
bugfixes: true,

// Apply smaller "loose" transforms for browsers
loose: browserslistEnv === 'javascripts',
loose: isBrowser,

// Transform ES modules for Node.js
modules: browserslistEnv === 'node' ? 'auto' : false
// Skip ES module transforms for browsers
modules: isBrowser ? false : 'auto'
}]
]
}
Expand Down

0 comments on commit bb9e80f

Please sign in to comment.