Skip to content

Commit

Permalink
Merge pull request #737 from alphagov/fix-ie8-components
Browse files Browse the repository at this point in the history
Fix a couple of IE8 issues
  • Loading branch information
36degrees authored May 31, 2018
2 parents 35a41ab + 3e999ac commit e98bd19
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 0 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,11 @@ Note: We're not following semantic versioning yet, we are going to talk about th
- Removed some duplicated CSS rules from the outputted CSS
([PR #727](https://github.com/alphagov/govuk-frontend/pull/727))

- Fixes a bug in IE8 where the button component did not have a shadow, by
rendering the shadow using a border for IE8 specifically – IE8 does not
support box-shadow
([PR #737])(https://github.com/alphagov/govuk-frontend/pull/737)


🆕 New features:

Expand Down
4 changes: 4 additions & 0 deletions src/components/breadcrumbs/_breadcrumbs.scss
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,10 @@
height: auto;
border: 0;
color: $chevron-border-colour;

// IE8 doesn't seem to like rendering pseudo-elements using @font-faces,
// so fall back to using another sans-serif font to render the chevron.
font-family: Arial, sans-serif;
}
}

Expand Down
8 changes: 8 additions & 0 deletions src/components/button/_button.scss
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@
cursor: pointer;
-webkit-appearance: none;

@include govuk-if-ie8 {
border-bottom: $button-shadow-size solid $govuk-button-shadow-colour;
}

@include mq($from: tablet) {
width: auto;
}
Expand Down Expand Up @@ -72,6 +76,10 @@
&:active {
top: $button-shadow-size;
box-shadow: none;

@include govuk-if-ie8 {
border-bottom-width: 0;
}
}

// The following adjustments do not work for <input type="button"> as
Expand Down

0 comments on commit e98bd19

Please sign in to comment.