Skip to content

Commit

Permalink
Ensure footer links look clickable
Browse files Browse the repository at this point in the history
We originally removed the underlines from these links to make them consistent with the approach we have for the header component.

In order to make sure these links look like links in this component I have reverted this change.

Original reasoning for removing underlines:
"
I believe the intention was to treat the links in the footer in the same way we treat other navigational elements – like the header, or in the case of the Design System the side navigation. Where the ‘thing’ is a ‘list of links’, the thinking is/was that they don’t need the underlining because there’s no wider context in which they need to be distinguished. The exception is any link that does appear within e.g. a paragraph, in which case it does need the underline to distinguish it. It has been questioned a few times on support recently though.

The benefit, I believe, is that it allows us to have a clear hover state for those links, which we didn’t previously have
"
  • Loading branch information
NickColley committed Dec 9, 2019
1 parent 8c3b2d2 commit fcee1e1
Showing 1 changed file with 0 additions and 13 deletions.
13 changes: 0 additions & 13 deletions src/govuk/components/footer/_footer.scss
Original file line number Diff line number Diff line change
Expand Up @@ -77,19 +77,6 @@
}
}

// Internet Explorer 8 does not support `:not()` selectors, so don't conditionally show underlines.
@include govuk-not-ie8 {
.govuk-footer__inline-list .govuk-footer__link,
.govuk-footer__list .govuk-footer__link {
text-decoration: none;

&:hover:not(:focus),
&:active:not(:focus) {
text-decoration: underline;
}
}
}

.govuk-footer__section-break {
margin: 0; // Reset `<hr>` default margins
@include govuk-responsive-margin(8, "bottom");
Expand Down

0 comments on commit fcee1e1

Please sign in to comment.