-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crown logo is not always aligned with logotype #1575
Comments
I believe something has happened to increase the header size by 4px, the crown has potentially just stayed in the same place? The header should be 50px / 60px with blue bar. Now 54px / 64px. Removing the svg puts it back to original size. |
When testing in browser stack, Chrome 75 is fine 76 is not. |
If you move the font sizing CSS to the child element it brings back the previous behaviour, with some small adjustments needed. Options:
|
@NickColley I nearly raised this yesterday as I've been working on an old project (GOV.UK Elements) and spotted the alignment difference! Can confirm in Chrome 77. |
something like this should have it aligned across FF, Safari and Chrome
width, height and top will align it to the baseline. negative top margin is to tweak offset a bit |
Short termWe're going to fix this in CSS Longer termWe've been thinking about replacing this with an inline SVG which includes the 'GOV.UK' text within the image itself. This would also mean that when the fallback fonts are loaded then the logo will be correct, this could be useful if we were to change the loading strategy to 'swap'. This would also include Internet Explorer 8 not loading the font. We'll create another issue once we've done the short term work. |
As found by @trevorsaint, it looks like adding |
Speaking with Dave it seems you can't reproduce this on his machine but I have been able to on Browserstack.
Safari shows the logo lower instead of higher.
The text was updated successfully, but these errors were encountered: