Fix height and alignment issue within header in Chrome 76+ #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1587
36degrees
changed the title
A change in Chrome 76 means that the header is currently being rendered 64px high (rather than the expected 60px), with mis-alignment between the crown and the GOV.UK logotype. Adding `display: inline-block` to the __logotype element fixes it. (We are not sure what exactly changed in Chrome 76, nor why this fixes it.) Co-authored-by: Trevor Saint <trevor.saint@digital.cabinet-office.gov.uk>
36degrees
force-pushed
the
header-alignment
branch
from
2e882ae
to
4cb8d01
Compare
NickColley
approved these changes
Sep 23, 2019
|
I've double checked and it renders exactly the same as the current header does in Chrome 75. |
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change in Chrome 76 means that the header is currently being rendered 64px high (rather than the expected 60px), with mis-alignment between the crown and the GOV.UK logotype.
Adding
display: inline-blockto the __logotype element fixes it (h/t @trevorsaint).(We are not sure what exactly changed in Chrome 76, nor why this fixes it.)
Fixes #1575
👉 Browser Screenshots
👉 Preview
Before
After