Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the date input to use text inputs with a numeric input mode #1700

Closed
8 tasks done
36degrees opened this issue Jan 17, 2020 · 1 comment · Fixed by #1527 or #1704
Closed
8 tasks done

Update the date input to use text inputs with a numeric input mode #1700

36degrees opened this issue Jan 17, 2020 · 1 comment · Fixed by #1527 or #1704
Assignees
Milestone

Comments

@36degrees
Copy link
Contributor

36degrees commented Jan 17, 2020

What

Update the date input so that each of the inputs is of type="text" with inputmode="numeric", rather than using type="number".

For now, we're going to keep the pattern attribute as it ensures the right keyboard is displayed for iOS < 12.2+ – we can review this when we stop seeing much traffic from these older versions.

Why

For context, see the results of the investigation in #1449

Who needs to know about this

Developers

Done when

  • Inputs within the date input component use type="text"
  • Inputs within the date input component use inputmode="numeric"
  • Tests for the above
  • Tested in the browsers / assistive technologies that we support

We should then:

@36degrees
Copy link
Contributor Author

36degrees commented Jan 17, 2020

@htmlandbacon has started working on this in #1599 – I've asked him if he's happy to make some changes to the PR, and we can pick this up next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
1 participant