Add inputmode option to the input component #1527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36degrees
reviewed
Aug 9, 2019
| @@ -42,5 +42,6 @@ | |||
| {%- if describedBy %} aria-describedby="{{ describedBy }}"{% endif %} | |||
| {%- if params.autocomplete %} autocomplete="{{ params.autocomplete}}"{% endif %} | |||
| {%- if params.pattern %} pattern="{{ params.pattern }}"{% endif %} | |||
| {%- if params.inputmode %} inputmode="{{ params.inputmode }}" {% endif %} | |||
There was a problem hiding this comment.
Minor, but no trailing space before {% endif %} – this will be followed by either the > or an attribute, and each attribute includes a leading space.
As it is, the outputted HTML would include an extra space:
…inputmode="decimal" >
…inputmode="decimal" data-attribute="blah">
Suggested change
| {%- if params.inputmode %} inputmode="{{ params.inputmode }}" {% endif %} | |
| {%- if params.inputmode %} inputmode="{{ params.inputmode }}"{% endif %} |
There was a problem hiding this comment.
Good spot, have updated 👍
| @@ -341,4 +348,15 @@ describe('Input', () => { | |||
| expect($component.attr('autocomplete')).toEqual('postal-code') | |||
| }) | |||
| }) | |||
|
|
|||
| describe('when it includes an inputmode', () => { | |||
There was a problem hiding this comment.
Thanks for adding a test for this 💯
|
Updated with the comments in mind 👍 |
36degrees
approved these changes
Aug 23, 2019
NickColley
approved these changes
Aug 27, 2019
|
Thanks Colin :) |
NickColley
changed the title
NickColley
changed the title
NickColley
changed the title
Merged
This was referenced Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the option of setting an optional inputmode.
One thing I couldn't see was an example of a check against something that isn't there by default?
I.e if inputmode="{{ params.inputmode }}" wasn't wrapped correctly it would always be there.
Just just added a check, happy to remove, or change if required.
I figured this was an easy step towards improving #1449 (comment)
Closes #1700