Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for onError callback to check usual logging does not happen #5303

Closed
2 tasks
Tracked by #5292
romaricpascal opened this issue Sep 10, 2024 · 0 comments
Closed
2 tasks
Tracked by #5292
Assignees

Comments

@romaricpascal
Copy link
Member

What

Address this comment in its own PR.

Why

We're currently testing that the callback is executed, but not that the initial logging no longer happens.
This should also simplify the tests a little as we wouldn't need the spy to log so we can then check that console.log was called.

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

Tests for the error callback using console.log in the spy now:

  • Check that the spy's been called with the right shape of arguments
  • Check that no logging happened
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready to release 🚀
Development

No branches or pull requests

2 participants