Change onError
tests to test console.log
not called
#5306
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update
onError
tests to testconsole.log
not called. Rewrite tests to instead check to see if the mockedonError
callback function was called with the correct arguments.Why
This is a better test of overriding the default functionality of error throwing because printing to console is the default behaviour of throwing errors in
initAll
andcreateAll
.Fixes #5303