-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing CHANGELOG entries for public JS API #5351
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-5351
September 24, 2024 12:27
Inactive
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for 14a81d6 |
romaricpascal
changed the title
Add missing CHANGELOG entries for public JS
Add missing CHANGELOG entries for public JS API
Sep 24, 2024
seaemsi
reviewed
Sep 25, 2024
seaemsi
reviewed
Sep 25, 2024
seaemsi
reviewed
Sep 25, 2024
seaemsi
reviewed
Sep 25, 2024
seaemsi
reviewed
Sep 25, 2024
seaemsi
reviewed
Sep 25, 2024
seaemsi
reviewed
Sep 25, 2024
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-5351
September 26, 2024 15:56
Inactive
romaricpascal
force-pushed
the
changelog-entries
branch
from
September 26, 2024 16:03
20a0559
to
16689f2
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-5351
September 26, 2024 16:03
Inactive
romaricpascal
force-pushed
the
changelog-entries
branch
from
September 26, 2024 16:04
16689f2
to
e253dbc
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-5351
September 26, 2024 16:05
Inactive
Co-authored-by: seaemsi <50173207+seaemsi@users.noreply.github.com>
Co-authored-by: seaemsi <50173207+seaemsi@users.noreply.github.com>
Co-authored-by: seaemsi <50173207+seaemsi@users.noreply.github.com>
romaricpascal
force-pushed
the
changelog-entries
branch
from
September 26, 2024 16:07
e253dbc
to
14a81d6
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-5351
September 26, 2024 16:07
Inactive
@seaemsi I've updated the changelog with all your suggestions. |
seaemsi
approved these changes
Sep 26, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing CHANGELOG entries for the PRs that were merged on
public-js-api
and provide public features.Each commit adds its own entry for easier review:
isSupported
toall.mjs
#5250onError
callback (AddonError
tocreateAll
#5252 and AddonError
toinitAll
#5276)Of the other PRs in the list:
checkSupport
madestatic
#5336 will be documented in the Frontend Docs when describing the base class, so thought we'd just link to the Frontend Docs rather than have a specific entry$module
to$root
across the codebase #5337, Encapsulate check for components support in method #5328, ChangeonError
tests to testconsole.log
not called #5306 are internal changesCloses #5321