Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove implicit dependency on Element for classList #1063

Merged
merged 2 commits into from
Nov 15, 2018
Merged

Remove implicit dependency on Element for classList #1063

merged 2 commits into from
Nov 15, 2018

Conversation

NickColley
Copy link
Contributor

@NickColley NickColley commented Nov 15, 2018 •
edited
Loading

Fixes #1044

I think we should also consider #674 since this will likely happen again.

From: https://cdn.polyfill.io/v2/polyfill.js?features=Element.prototype.classList&flags=always

  • Object.defineProperty, License: CC0 (required by "Element.prototype.classList", "_DOMTokenList", "DOMTokenList")
  • _DOMTokenList, License: ISC (required by "DOMTokenList", "Element.prototype.classList")
  • DOMTokenList, License: CC0 (required by "Element.prototype.classList")
  • Document, License: CC0 (required by "Element", "Element.prototype.classList")
  • Element, License: CC0 (required by "Element.prototype.classList")
  • Element.prototype.classList, License: ISC

We can remove the import from the design system after this ships: https://github.com/alphagov/govuk-design-system/pull/596/files#diff-9f975bd4d01eb71ff7e1ecad9f2a0484R2

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1063 November 15, 2018 13:50 Inactive
This was referenced Nov 15, 2018
Closed
Merged
kr8n3r
kr8n3r approved these changes Nov 15, 2018
View reviewed changes
Copy link

@kr8n3r kr8n3r left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
I think it's mostly internal, but does it warrant a line in the fixes block?

@NickColley
Copy link
Contributor Author

Oops yes this needs a CHANGELOG entry

@kr8n3r
Copy link

kr8n3r commented Nov 15, 2018

👍

@kr8n3r kr8n3r added this to the [NEXT] milestone Nov 15, 2018
@NickColley NickColley merged commit e7cfd47 into master Nov 15, 2018
@NickColley NickColley deleted the fix-implicit-polyfill-dependency branch November 15, 2018 15:00
@kr8n3r kr8n3r mentioned this pull request Nov 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kr8n3r kr8n3r kr8n3r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@NickColley @kr8n3r @govuk-design-system-ci