Remove hover state for accordion sections on mobile #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On iOS the hover state could be 'stuck' when the user is not interacting with the accordion component anymore. One alternative approach would be to only add a hover state when the device has hover capability, I chose not to do this since this feature is techincally still a candidate recommendation which means it could in theory be removed if something happens while they test this new feature. In the future we could simplify this code if it becomes a stable recommendation.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1148
36degrees
approved these changes
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On iOS the hover state could be 'stuck' when the user is not interacting with the accordion component anymore.
One alternative approach would be to only add a hover state when the device has hover capability, I chose not to do this since this feature is techincally still a candidate recommendation which means it could in theory be removed if something happens while they test this new feature.
In the future we could simplify this code if it becomes a stable recommendation.
Fixes #1143