Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes styling of accordion when there is no js #1149

Merged
merged 1 commit into from
Jan 18, 2019

Conversation

aliuk2012
Copy link
Contributor

@aliuk2012 aliuk2012 commented Jan 18, 2019

fixes #1130

@dashouse could you review this PR too?

image

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1149 January 18, 2019 12:15 Inactive
@dashouse dashouse self-requested a review January 18, 2019 12:43
Copy link

@dashouse dashouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@NickColley NickColley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, need a changelog entry 👍

@aliuk2012 aliuk2012 changed the title Fixes up styling of accordion when there is no js Fixes styling of accordion when there is no js Jan 18, 2019
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1149 January 18, 2019 14:23 Inactive
CHANGELOG.md Outdated

Thanks @dankmitchell for reporting this issue ([#1130](https://github.com/alphagov/govuk-frontend/issues/1130))

([PR #N](https://github.com/alphagov/govuk-frontend/pull/N))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs the PR number 🙂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You beat me to it ;) I had to fix the conflicts first

@aliuk2012 aliuk2012 force-pushed the al/fix-accordion-no-js branch from 2d17eb8 to 14e3530 Compare January 18, 2019 14:36
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1149 January 18, 2019 14:36 Inactive
@aliuk2012 aliuk2012 force-pushed the al/fix-accordion-no-js branch from 14e3530 to 9df0ac4 Compare January 18, 2019 14:44
@aliuk2012 aliuk2012 merged commit e70f59d into master Jan 18, 2019
@aliuk2012 aliuk2012 deleted the al/fix-accordion-no-js branch January 18, 2019 15:04
@NickColley NickColley added this to the [NEXT] milestone Jan 21, 2019
This was referenced Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accordion non-js spacing on headers
5 participants