DNM: Add News and Comms with sorting and small form controls #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to shuffle a data set in a deterministic way Co-authored-by: Nick Colley <nick.colley@digital.cabinet-office.gov.uk>
Since we're shuffling one data set we don't need the different variations anymore Co-authored-by: Nick Colley <nick.colley@digital.cabinet-office.gov.uk>
Add small form inputs to view. Remove error validation from filters as we cover this with another example. Co-authored-by: Nick Colley <nick.colley@digital.cabinet-office.gov.uk>
We only want to to test News and Comms on this branch
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1212
hannalaakso
added a commit
that referenced
this pull request
Feb 21, 2019
We will test it in a separate branch: #1212
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-audit
hannalaakso
changed the title
|
We have created a permanent staging application for this branch so that heroku does not consider it stale. http://govuk-frontend-review-audit.herokuapp.com/full-page-examples/news-and-communications It should be removed when we are done with this branch. |
|
Now that small controls has shipped, should we tidy this up and merge it? |
|
Closing in favour of #1300 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the News and Comms page for the accessibility audit.
It's branched off #1125 to get the new small form controls work.
We've removed the other full page examples from this branch as we intend to give the version in this branch to test separately.