Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal programmatic and data attribute api interface for components. #1238

Closed
wants to merge 3 commits into from

Conversation

NickColley
Copy link
Contributor

@NickColley NickColley commented Mar 5, 2019

This is a scrappy branch to explore the practical impact of adding a data api alongside an programmatic api.

I've opened this draft so I can share code examples and review application links in the official proposal.

Inspired by Bootstraps data API

This will go into an fleshed out architecture proposal and aims to solve issues #1215 in a more long term way.

Notes:

Which should win programmatic or data api when both is set?

Should we be cohercing all data to their types we expect, or everything to strings?
@alex-ju
Copy link
Contributor

alex-ju commented Mar 5, 2019

Shall we consider tabs and accordion components too?

@NickColley
Copy link
Contributor Author

@alex-ju tabs doesnt seem to have any options that we could test this with, but accordion seems like a good shout

@NickColley
Copy link
Contributor Author

Closing this but will leave the branch up for us to come back to.

See #1223 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants