Update colour for MHCLG #1319
Merged
Update colour for MHCLG #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bevanloon
approved these changes
May 8, 2019
36degrees
approved these changes
May 8, 2019
NickColley
approved these changes
May 8, 2019
There was a problem hiding this comment.
This is looking great @thomasleese, I think if you add a CHANGELOG entry we'll be good to go.
|
@NickColley Thanks, I've updated the CHANGELOG now. |
NickColley
reviewed
May 8, 2019
| @@ -22,11 +22,11 @@ | |||
|
|
|||
| 🔧 Fixes: | |||
|
|
|||
| - Pull Request Title goes here | |||
| - Update colour for MHCLG | |||
There was a problem hiding this comment.
If possible could you leave the template behind so that future people updating the CHANGELOG can use it? I can do this for you if you'd like, lemme know :)
There was a problem hiding this comment.
No problem, I've amended the commit and also put in a ## Template header, if that's helpful.
Fixes the brand colour for MHCLG to their correct corporate "green" brand. Closes #1301. [Trello Card](https://trello.com/c/wqKT3TpE/621-change-mhclgs-brand-colour)
|
It doesn't look like I have permission to merge this. |
|
@NickColley are you happy with the PR now? If so, would you do the honours and merge please? Neither Tom nor I have merge permissions |
|
Thanks both :) |
This was referenced May 28, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1301.
Trello Card