Update tabs component to WCAG 2.1 compliant focus style #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1326
hannalaakso
force-pushed
the
update-tabs-to-use-2-1
branch
from
7eb7652
to
c0698a6
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1326
36degrees
reviewed
May 9, 2019
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1326
IE8 doesn’t support box-shadow so use border to indicate state. To prevent “jump” in selected state, make adjustments as this state modifies border width. Only use the black top border from the design which uses box-shadow to achieve a double border.
hannalaakso
force-pushed
the
update-tabs-to-use-2-1
branch
from
3b57efe
to
81809d0
Compare
hannalaakso
added a commit
that referenced
this pull request
May 9, 2019
Split from #1326 This amends the tab headings spacing on mobile and no-js view to be consistent with how we present the navigation on the Design System: Adjusts the padding/margin so that with the the list version of component that’s used on mobile and no-js we use have govuk-spacing(2) as bottom margin, consistent with what we do with on-page navigation in GOV.UK Design System when it's displayed as a list. For the desktop/js-enabled version of component remove bottom margin and use top and bottom padding instead. Also adjusts bottom margin of list item so that it’s applied on no-js version and add some more spacing under the tabs title.
hannalaakso
added a commit
that referenced
this pull request
May 9, 2019
Split from #1326 This amends the tab headings spacing on mobile and no-js view to be consistent with how we present the navigation on the Design System: Adjusts the padding/margin so that with the the list version of component that’s used on mobile and no-js we use have govuk-spacing(2) as bottom margin, consistent with what we do with on-page navigation in GOV.UK Design System when it's displayed as a list. For the desktop/js-enabled version of component remove bottom margin and use top and bottom padding instead. Also adjusts bottom margin of list item so that it’s applied on no-js version and add some more spacing under the tabs title.
hannalaakso
added a commit
that referenced
this pull request
May 9, 2019
Split from #1326 This amends the tab headings spacing on mobile and no-js view to be consistent with how we present the navigation on the Design System: Adjusts the padding/margin so that with the the list version of component that’s used on mobile and no-js we use have govuk-spacing(2) as bottom margin, consistent with what we do with on-page navigation in GOV.UK Design System when it's displayed as a list. For the desktop/js-enabled version of component remove bottom margin and use top and bottom padding instead. Also adjusts bottom margin of list item so that it’s applied on no-js version and add some more spacing under the tabs title.
NickColley
reviewed
May 9, 2019
| background-color: transparent; | ||
| box-shadow: inset 0 4px 0 0 $govuk-focus-colour, inset 0 8px 0 0 govuk-colour("black"); | ||
|
|
||
| @include govuk-if-ie8 { |
There was a problem hiding this comment.
In the accordion component I've put a border + a smaller box-shadow for all browsers, which allows you to avoid the special IE8 wrapper stuff.
Not sure if it'd work here, but means it fallsback automatically without conditional stylesheets.
There was a problem hiding this comment.
Thanks @NickColley. Happy to revisit this after the audit and there's also this to consider: #1327
NickColley
approved these changes
May 9, 2019
hannalaakso
added a commit
that referenced
this pull request
May 10, 2019
Split from #1326 This amends the tab headings spacing on mobile and no-js view to be consistent with how we present the navigation on the Design System: Adjusts the padding/margin so that with the the list version of component that’s used on mobile and no-js we use have govuk-spacing(2) as bottom margin, consistent with what we do with on-page navigation in GOV.UK Design System when it's displayed as a list. For the desktop/js-enabled version of component remove bottom margin and use top and bottom padding instead. Also adjusts bottom margin of list item so that it’s applied on no-js version and add some more spacing under the tabs title.
hannalaakso
added a commit
that referenced
this pull request
May 10, 2019
Split from #1326 This amends the tab headings spacing on mobile and no-js view to be consistent with how we present the navigation on the Design System: Adjusts the padding/margin so that with the the list version of component that’s used on mobile and no-js we use have govuk-spacing(2) as bottom margin, consistent with what we do with on-page navigation in GOV.UK Design System when it's displayed as a list. For the desktop/js-enabled version of component remove bottom margin and use top and bottom padding instead. Also adjusts bottom margin of list item so that it’s applied on no-js version and add some more spacing under the tabs title.
7 tasks
aliuk2012
pushed a commit
that referenced
this pull request
Jun 14, 2019
Split from #1326 This amends the tab headings spacing on mobile and no-js view to be consistent with how we present the navigation on the Design System: Adjusts the padding/margin so that with the the list version of component that’s used on mobile and no-js we use have govuk-spacing(2) as bottom margin, consistent with what we do with on-page navigation in GOV.UK Design System when it's displayed as a list. For the desktop/js-enabled version of component remove bottom margin and use top and bottom padding instead. Also adjusts bottom margin of list item so that it’s applied on no-js version and add some more spacing under the tabs title.
aliuk2012
pushed a commit
that referenced
this pull request
Jun 14, 2019
Split from #1326 This amends the tab headings spacing on mobile and no-js view to be consistent with how we present the navigation on the Design System: Adjusts the padding/margin so that with the the list version of component that’s used on mobile and no-js we use have govuk-spacing(2) as bottom margin, consistent with what we do with on-page navigation in GOV.UK Design System when it's displayed as a list. For the desktop/js-enabled version of component remove bottom margin and use top and bottom padding instead. Also adjusts bottom margin of list item so that it’s applied on no-js version and add some more spacing under the tabs title.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterate on #1245 to update the GOV.UK Frontend tabs component.
Solution implemented to support IE8
Tested in:
✅ Chrome 74
✅ Firefox 66 (including with overridden colours)
✅ Mac OS Safari 12.1
✅ Android Samsung Galaxy (Chrome)
✅ iOS XS / 8 (Safari)
✅ Edge 18
✅ Edge 16
✅ IE 9-11
✅ IE8 - see comments above
✅With Javascript disabled
✅ In review app "legacy" mode
Fixes #1306