Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated @else-if statement, replace with @else if #1333

Merged
merged 1 commit into from
May 13, 2019

Conversation

gunjam
Copy link
Contributor

@gunjam gunjam commented May 10, 2019

When compiling with the sass npm module I'm getting the following deprecation warning:

DEPRECATION WARNING on line 145, column 7 of node_modules/govuk-frontend/helpers/_typography.scss:
@elseif is deprecated and will not be supported in future Sass versions.
Use "@else if" instead.
    ╷
145 │     } @elseif $breakpoint == "print" {
    │       ^^^^^^^
    ╵

This should fix the issue, while still sucessfully building with the node-sass package.

@36degrees
Copy link
Contributor

Thanks for this, @gunjam!

Would you mind adding an entry to the changelog?

This will then need another review from someone else on the team before we can get it merged. It's also worth mentioning that we're currently working towards a 3.0 release and so it may take a while before this actually goes out.

@gunjam gunjam changed the title fix: remove deprecated @else-if statement, replace with @else if Remove deprecated @else-if statement, replace with @else if May 10, 2019
@gunjam
Copy link
Contributor Author

gunjam commented May 10, 2019

Hi @36degrees, I updated CHANGELOG.md, did I do it right? :)

@36degrees
Copy link
Contributor

Bang on 👌– thanks!

Copy link
Contributor

@NickColley NickColley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work thanks :)

@NickColley NickColley merged commit fea29aa into alphagov:master May 13, 2019
@NickColley NickColley added this to the v2.12.0 milestone May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants