SPIKE - Add v2 font #1356

dashouse · 2019-05-16T13:27:00Z

This PR uses v2 of the font.

Adds new font files, reducing the amount of files from 12 to 8
Significantly better alignment with the baseline of Helvetica / Arial*
Tabular numbers are now rolled up in to the Light or Bold weights and set with font-feature-settings (CSS applied to existing mixin so $tabular: true still works)
NTA specific overrides on "Button" and "Tag" have been removed

*This is somewhat dependent on font size. Frustratingly for us 19px is still not entirely aligned.

Tag before

Tag after

Header before (Note position of Service name - Component may need adjustment of crown and top padding)

Header after

Discoveries

FIXED, see comment below. The header appears to have got larger (65px to 66.16px (1.78%)) suggesting there is a change to how the font takes up space. This was to do with a mixture of the SVG height and vertical position. The header is now 60px regardless of font.

Overlay of example page to show the difference.
Note general page scaffolding is intact, images, footer etc in exactly the same position despite text shift.

src/components/button/_button.scss

src/helpers/_font-faces.scss

NickColley · 2019-05-17T09:13:28Z

src/helpers/_typography.scss

@@ -171,7 +171,13 @@

 @mixin govuk-font($size, $weight: regular, $tabular: false, $line-height: false) {
  @if $tabular {
-    @include govuk-typography-common($font-family: $govuk-font-family-tabular);
+    @include govuk-typography-common;


I think this might need the compatibility stuff here as well

NickColley · 2019-05-17T09:14:22Z

src/helpers/_font-faces.scss

@@ -21,47 +21,26 @@

      @font-face {


I believe that we don't need to have the old fonts around here since GOVUK_Template will supply these?

This font-face is already automatically excluded when certain compat flags are present, something to double check.

The old fonts are already gone, unless you mean get rid of the .eot versions etc?

When legacy mode is enabled, GOV.UK Frontend font-face declarations are not output and GOV.UK Frontend relies on GOVUK_Template being loaded alongside.

So this means we don't need to keep the old fonts around in GOV.UK Frontend, but we should check this.

NickColley · 2019-05-17T09:14:50Z

src/settings/_typography-font-families.scss

-/// @type List
-/// @access public
-
-$govuk-font-family-nta-tabular: "ntatabularnumbers", $govuk-font-family-nta;


Again probably will need to keep this around for the legacy mode...?

dashouse · 2019-05-20T07:56:28Z

Header issue resolved:

With NTA (60px)

With Arial (60px)

GOV.UK's header is 53px (3px padding top is to compensate for transport)
Current header in the design system is 65px (-10 for blue border = 55px)

This change makes the header 60px (50px without border) regardless of font. Which is what I believe to be the desired size.

I've added this import for compatibility variables because in the design system there is a method that uses sass-exports to export the _colours palette but fails to run because the compatibility variables cannot be set.

Nooshu · 2019-05-22T09:30:58Z

I'd recommend removing the EOT versions of the fonts from the @font-face declaration. Only IE support this font format (including IE11). All but IE8 also support other font formats that are available. According to the last 30 days GOV.UK analytics, IE8 has had 9,054 "users" out of 50,566,007 (0.018%).

EOT files can be compressed with Gzip (or Zopfli for 5% better compression), but even with this compression we are asking old browsers on legacy devices to download a fairly large amount of data (60KB) for unhinted versions of the font (only Vista and XP require hinted versions). These browsers and devices are the least equipped to manage these assets.

Font	Size (bytes)	Saving (bytes)	Saving (%)
Bold EOT uncompressed	58932	0	0
Bold EOT gzipped	30366	28566	48.4
Bold EOT zopfli	28115	30817	52.3
Light EOT uncompressed	58708	0	0
Light EOT gzipped	29885	28823	49.1
Light EOT zopfli	27589	31119	53

Totals: Uncompressed download - 118KB, Compressed (gzip) - 60KB, Compressed (Zopfli) - 56KB.

I'd say it's a better strategy for this small number of devices is to use the fallback font of Arial, and not have them require to download the additional EOT assets. Since the new font now corrects the glyph placement in the bounding box, the fallback will render correctly without the need for additional adjustments to the vertical placement.

If it is we decide to keep the EOT files in the @font-face declaration it's worth noting the container order will prevent IE9-11 from receiving the WOFF version of the font. Browsers pick the first font format it supports from the list. It will ignore any declarations after, (even if they are also supported). In the current setup IE9, 10 and 11 will download the EOT format even though they all support WOFF.

Since WOFF files are already compressed using Gzip compression, developers don't need to worry about enabling compression on the server. If developers forget to enable Gzip compression on the server for EOT files (since we can't provide compressed versions of the EOT files) these users will be downloading 118KB vs 83KB (WOFF). Due to all the hacks required to make fonts work properly in older versions of IE there looks to be no way around this. This seems like another good reason to remove the EOT sources from the declaration.

Recommended declaration

@font-face {
    font-family: "nta";
    src: govuk-font-url("light-68f0c84f0e-v2.woff2") format("woff2"),
         govuk-font-url("light-222368e53d-v2.woff") format("woff");
    font-weight: normal;
    font-style: normal;
    font-display: swap;
}

@font-face {
    font-family: "nta";
    src: govuk-font-url("bold-9561e2d007-v2.woff2") format("woff2"),
         govuk-font-url("bold-5d3836b441-v2.woff") format("woff");
    font-weight: bold;
    font-style: normal;
    font-display: swap;
}

NickColley · 2019-05-22T09:38:41Z

It won't block this work since it's already an issue, but we should consider making the logo entirely an image which includes the crown and the text, so that in browsers that don't have the font they still get the correct branding.

@Nooshu

Embedded Open Type (.eot) is a proprietary format, which no other browsers use apart from IE8 and older. As v2 font is so similiar to Arial, we have decided to remove EOT format. This means that IE8 and older will not be downloading any custom fonts like v1 and v2 of Transport but will instead use Arial by default. This commit also fixes an existing issue with IE 9-11 using EOT format by default instead of WOFF. This is because the browser would only look for and use the first format it finds that it supports. Thanks goes to Matthew Hobbs (@Nooshu)[https://github.com/Nooshu] for this recommendation. An extract of Matt's recommendation can be found below and at this link: #1356 (comment) I'd recommend removing the EOT versions of the fonts from the `@font-face` declaration. Only IE support this font format (including IE11). All but IE8 also support other font formats that are available. According to the last 30 days GOV.UK analytics, IE8 has had 9,054 "users" out of 50,566,007 (0.018%). EOT files can be compressed with Gzip (or Zopfli for 5% better compression), but even with this compression we are asking old browsers on legacy devices to download a fairly large amount of data (60KB) for unhinted versions of the font ([only Vista and XP require hinted versions](https://docs.google.com/spreadsheets/d/1l2SKP9D3Fm5EVk10j9K1CUSg_jCkW7Pef60TzK0ZKlI/edit#gid=0)). These browsers and devices are the least equipped to manage these assets. Font | Size (bytes) | Saving (bytes) | Saving (%) ------------ | ------------- | ------------- | ------------- Bold EOT uncompressed | 58932 | 0 | 0 Bold EOT gzipped | 30366 | 28566 | 48.4 Bold EOT zopfli | 28115 | 30817 | 52.3 Light EOT uncompressed | 58708 | 0 | 0 Light EOT gzipped | 29885 | 28823 | 49.1 Light EOT zopfli | 27589 | 31119 | 53 **Totals**: Uncompressed download - 118KB, Compressed (gzip) - 60KB, Compressed (Zopfli) - 56KB. I'd say it's a better strategy for this small number of devices is to use the fallback font of Arial, and not have them require to download the additional EOT assets. Since the new font now corrects the glyph placement in the bounding box, the fallback will render correctly without the need for additional adjustments to the vertical placement. If it is we decide to keep the EOT files in the `@font-face` declaration it's worth noting the container order will prevent IE9-11 from receiving the WOFF version of the font. Browsers pick the first font format it supports from the list. It will ignore any declarations after, (even if they are also supported). In the current setup IE9, 10 and 11 will download the EOT format even though they all support WOFF. Since WOFF files are already compressed using Gzip compression, developers don't need to worry about enabling compression on the server. If developers forget to enable Gzip compression on the server for EOT files (since we can't provide compressed versions of the EOT files) these users will be downloading 118KB vs 83KB (WOFF). Due to [all the hacks required](https://www.paulirish.com/2009/bulletproof-font-face-implementation-syntax/) to make fonts work properly in older versions of IE there looks to be no way around this. This seems like another good reason to remove the EOT sources from the declaration. Recommended declaration ```css @font-face { font-family: "nta"; src: govuk-font-url("light-68f0c84f0e-v2.woff2") format("woff2"), govuk-font-url("light-222368e53d-v2.woff") format("woff"); font-weight: normal; font-style: normal; font-display: swap; } @font-face { font-family: "nta"; src: govuk-font-url("bold-9561e2d007-v2.woff2") format("woff2"), govuk-font-url("bold-5d3836b441-v2.woff") format("woff"); font-weight: bold; font-style: normal; font-display: swap; } ```

aliuk2012 · 2019-06-06T10:07:36Z

This PR will be split into two different PR.

Replacing v1 font with v2 (PR Update font to use v2 of GOV.UK Transport font. #1434)
Removing NTA specific overrides on "Button" and "Tag" etc

@Nooshu

Embedded Open Type (.eot) is a proprietary format, which no other browsers use apart from IE8 and older. As v2 font is so similiar to Arial, we have decided to remove EOT format. This means that IE8 and older will not be downloading any custom fonts like v1 and v2 of Transport but will instead use Arial by default. This commit also fixes an existing issue with IE 9-11 using EOT format by default instead of WOFF. This is because the browser would only look for and use the first format it finds that it supports. Thanks goes to Matthew Hobbs (@Nooshu)[https://github.com/Nooshu] for this recommendation. An extract of Matt's recommendation can be found below and at this link: #1356 (comment) I'd recommend removing the EOT versions of the fonts from the `@font-face` declaration. Only IE support this font format (including IE11). All but IE8 also support other font formats that are available. According to the last 30 days GOV.UK analytics, IE8 has had 9,054 "users" out of 50,566,007 (0.018%). EOT files can be compressed with Gzip (or Zopfli for 5% better compression), but even with this compression we are asking old browsers on legacy devices to download a fairly large amount of data (60KB) for unhinted versions of the font ([only Vista and XP require hinted versions](https://docs.google.com/spreadsheets/d/1l2SKP9D3Fm5EVk10j9K1CUSg_jCkW7Pef60TzK0ZKlI/edit#gid=0)). These browsers and devices are the least equipped to manage these assets. Font | Size (bytes) | Saving (bytes) | Saving (%) ------------ | ------------- | ------------- | ------------- Bold EOT uncompressed | 58932 | 0 | 0 Bold EOT gzipped | 30366 | 28566 | 48.4 Bold EOT zopfli | 28115 | 30817 | 52.3 Light EOT uncompressed | 58708 | 0 | 0 Light EOT gzipped | 29885 | 28823 | 49.1 Light EOT zopfli | 27589 | 31119 | 53 **Totals**: Uncompressed download - 118KB, Compressed (gzip) - 60KB, Compressed (Zopfli) - 56KB. I'd say it's a better strategy for this small number of devices is to use the fallback font of Arial, and not have them require to download the additional EOT assets. Since the new font now corrects the glyph placement in the bounding box, the fallback will render correctly without the need for additional adjustments to the vertical placement. If it is we decide to keep the EOT files in the `@font-face` declaration it's worth noting the container order will prevent IE9-11 from receiving the WOFF version of the font. Browsers pick the first font format it supports from the list. It will ignore any declarations after, (even if they are also supported). In the current setup IE9, 10 and 11 will download the EOT format even though they all support WOFF. Since WOFF files are already compressed using Gzip compression, developers don't need to worry about enabling compression on the server. If developers forget to enable Gzip compression on the server for EOT files (since we can't provide compressed versions of the EOT files) these users will be downloading 118KB vs 83KB (WOFF). Due to [all the hacks required](https://www.paulirish.com/2009/bulletproof-font-face-implementation-syntax/) to make fonts work properly in older versions of IE there looks to be no way around this. This seems like another good reason to remove the EOT sources from the declaration. Recommended declaration ```css @font-face { font-family: "nta"; src: govuk-font-url("light-68f0c84f0e-v2.woff2") format("woff2"), govuk-font-url("light-222368e53d-v2.woff") format("woff"); font-weight: normal; font-style: normal; font-display: swap; } @font-face { font-family: "nta"; src: govuk-font-url("bold-9561e2d007-v2.woff2") format("woff2"), govuk-font-url("bold-5d3836b441-v2.woff") format("woff"); font-weight: bold; font-style: normal; font-display: swap; } ```

@Nooshu

Embedded Open Type (.eot) is a proprietary format, which no other browsers use apart from IE8 and older. As v2 font is so similiar to Arial, we have decided to remove EOT format. This means that IE8 and older will not be downloading any custom fonts like v1 and v2 of Transport but will instead use Arial by default. This commit also fixes an existing issue with IE 9-11 using EOT format by default instead of WOFF. This is because the browser would only look for and use the first format it finds that it supports. Thanks goes to Matthew Hobbs (@Nooshu)[https://github.com/Nooshu] for this recommendation. An extract of Matt's recommendation can be found below and at this link: #1356 (comment) I'd recommend removing the EOT versions of the fonts from the `@font-face` declaration. Only IE support this font format (including IE11). All but IE8 also support other font formats that are available. According to the last 30 days GOV.UK analytics, IE8 has had 9,054 "users" out of 50,566,007 (0.018%). EOT files can be compressed with Gzip (or Zopfli for 5% better compression), but even with this compression we are asking old browsers on legacy devices to download a fairly large amount of data (60KB) for unhinted versions of the font ([only Vista and XP require hinted versions](https://docs.google.com/spreadsheets/d/1l2SKP9D3Fm5EVk10j9K1CUSg_jCkW7Pef60TzK0ZKlI/edit#gid=0)). These browsers and devices are the least equipped to manage these assets. Font | Size (bytes) | Saving (bytes) | Saving (%) ------------ | ------------- | ------------- | ------------- Bold EOT uncompressed | 58932 | 0 | 0 Bold EOT gzipped | 30366 | 28566 | 48.4 Bold EOT zopfli | 28115 | 30817 | 52.3 Light EOT uncompressed | 58708 | 0 | 0 Light EOT gzipped | 29885 | 28823 | 49.1 Light EOT zopfli | 27589 | 31119 | 53 **Totals**: Uncompressed download - 118KB, Compressed (gzip) - 60KB, Compressed (Zopfli) - 56KB. I'd say it's a better strategy for this small number of devices is to use the fallback font of Arial, and not have them require to download the additional EOT assets. Since the new font now corrects the glyph placement in the bounding box, the fallback will render correctly without the need for additional adjustments to the vertical placement. If it is we decide to keep the EOT files in the `@font-face` declaration it's worth noting the container order will prevent IE9-11 from receiving the WOFF version of the font. Browsers pick the first font format it supports from the list. It will ignore any declarations after, (even if they are also supported). In the current setup IE9, 10 and 11 will download the EOT format even though they all support WOFF. Since WOFF files are already compressed using Gzip compression, developers don't need to worry about enabling compression on the server. If developers forget to enable Gzip compression on the server for EOT files (since we can't provide compressed versions of the EOT files) these users will be downloading 118KB vs 83KB (WOFF). Due to [all the hacks required](https://www.paulirish.com/2009/bulletproof-font-face-implementation-syntax/) to make fonts work properly in older versions of IE there looks to be no way around this. This seems like another good reason to remove the EOT sources from the declaration. Recommended declaration ```css @font-face { font-family: "nta"; src: govuk-font-url("light-68f0c84f0e-v2.woff2") format("woff2"), govuk-font-url("light-222368e53d-v2.woff") format("woff"); font-weight: normal; font-style: normal; font-display: swap; } @font-face { font-family: "nta"; src: govuk-font-url("bold-9561e2d007-v2.woff2") format("woff2"), govuk-font-url("bold-5d3836b441-v2.woff") format("woff"); font-weight: bold; font-style: normal; font-display: swap; } ```

aliuk2012 · 2019-06-11T14:43:24Z

Closing this as #1434 and #1441 have been merged

@Nooshu

Embedded Open Type (.eot) is a proprietary format, which no other browsers use apart from IE8 and older. As v2 font is so similiar to Arial, we have decided to remove EOT format. This means that IE8 and older will not be downloading any custom fonts like v1 and v2 of Transport but will instead use Arial by default. This commit also fixes an existing issue with IE 9-11 using EOT format by default instead of WOFF. This is because the browser would only look for and use the first format it finds that it supports. Thanks goes to Matthew Hobbs (@Nooshu)[https://github.com/Nooshu] for this recommendation. An extract of Matt's recommendation can be found below and at this link: #1356 (comment) I'd recommend removing the EOT versions of the fonts from the `@font-face` declaration. Only IE support this font format (including IE11). All but IE8 also support other font formats that are available. According to the last 30 days GOV.UK analytics, IE8 has had 9,054 "users" out of 50,566,007 (0.018%). EOT files can be compressed with Gzip (or Zopfli for 5% better compression), but even with this compression we are asking old browsers on legacy devices to download a fairly large amount of data (60KB) for unhinted versions of the font ([only Vista and XP require hinted versions](https://docs.google.com/spreadsheets/d/1l2SKP9D3Fm5EVk10j9K1CUSg_jCkW7Pef60TzK0ZKlI/edit#gid=0)). These browsers and devices are the least equipped to manage these assets. Font | Size (bytes) | Saving (bytes) | Saving (%) ------------ | ------------- | ------------- | ------------- Bold EOT uncompressed | 58932 | 0 | 0 Bold EOT gzipped | 30366 | 28566 | 48.4 Bold EOT zopfli | 28115 | 30817 | 52.3 Light EOT uncompressed | 58708 | 0 | 0 Light EOT gzipped | 29885 | 28823 | 49.1 Light EOT zopfli | 27589 | 31119 | 53 **Totals**: Uncompressed download - 118KB, Compressed (gzip) - 60KB, Compressed (Zopfli) - 56KB. I'd say it's a better strategy for this small number of devices is to use the fallback font of Arial, and not have them require to download the additional EOT assets. Since the new font now corrects the glyph placement in the bounding box, the fallback will render correctly without the need for additional adjustments to the vertical placement. If it is we decide to keep the EOT files in the `@font-face` declaration it's worth noting the container order will prevent IE9-11 from receiving the WOFF version of the font. Browsers pick the first font format it supports from the list. It will ignore any declarations after, (even if they are also supported). In the current setup IE9, 10 and 11 will download the EOT format even though they all support WOFF. Since WOFF files are already compressed using Gzip compression, developers don't need to worry about enabling compression on the server. If developers forget to enable Gzip compression on the server for EOT files (since we can't provide compressed versions of the EOT files) these users will be downloading 118KB vs 83KB (WOFF). Due to [all the hacks required](https://www.paulirish.com/2009/bulletproof-font-face-implementation-syntax/) to make fonts work properly in older versions of IE there looks to be no way around this. This seems like another good reason to remove the EOT sources from the declaration. Recommended declaration ```css @font-face { font-family: "nta"; src: govuk-font-url("light-68f0c84f0e-v2.woff2") format("woff2"), govuk-font-url("light-222368e53d-v2.woff") format("woff"); font-weight: normal; font-style: normal; font-display: swap; } @font-face { font-family: "nta"; src: govuk-font-url("bold-9561e2d007-v2.woff2") format("woff2"), govuk-font-url("bold-5d3836b441-v2.woff") format("woff"); font-weight: bold; font-style: normal; font-display: swap; } ```

@Nooshu

Embedded Open Type (.eot) is a proprietary format, which no other browsers use apart from IE8 and older. As v2 font is so similiar to Arial, we have decided to remove EOT format. This means that IE8 and older will not be downloading any custom fonts like v1 and v2 of Transport but will instead use Arial by default. This commit also fixes an existing issue with IE 9-11 using EOT format by default instead of WOFF. This is because the browser would only look for and use the first format it finds that it supports. Thanks goes to Matthew Hobbs (@Nooshu)[https://github.com/Nooshu] for this recommendation. An extract of Matt's recommendation can be found below and at this link: #1356 (comment) I'd recommend removing the EOT versions of the fonts from the `@font-face` declaration. Only IE support this font format (including IE11). All but IE8 also support other font formats that are available. According to the last 30 days GOV.UK analytics, IE8 has had 9,054 "users" out of 50,566,007 (0.018%). EOT files can be compressed with Gzip (or Zopfli for 5% better compression), but even with this compression we are asking old browsers on legacy devices to download a fairly large amount of data (60KB) for unhinted versions of the font ([only Vista and XP require hinted versions](https://docs.google.com/spreadsheets/d/1l2SKP9D3Fm5EVk10j9K1CUSg_jCkW7Pef60TzK0ZKlI/edit#gid=0)). These browsers and devices are the least equipped to manage these assets. Font | Size (bytes) | Saving (bytes) | Saving (%) ------------ | ------------- | ------------- | ------------- Bold EOT uncompressed | 58932 | 0 | 0 Bold EOT gzipped | 30366 | 28566 | 48.4 Bold EOT zopfli | 28115 | 30817 | 52.3 Light EOT uncompressed | 58708 | 0 | 0 Light EOT gzipped | 29885 | 28823 | 49.1 Light EOT zopfli | 27589 | 31119 | 53 **Totals**: Uncompressed download - 118KB, Compressed (gzip) - 60KB, Compressed (Zopfli) - 56KB. I'd say it's a better strategy for this small number of devices is to use the fallback font of Arial, and not have them require to download the additional EOT assets. Since the new font now corrects the glyph placement in the bounding box, the fallback will render correctly without the need for additional adjustments to the vertical placement. If it is we decide to keep the EOT files in the `@font-face` declaration it's worth noting the container order will prevent IE9-11 from receiving the WOFF version of the font. Browsers pick the first font format it supports from the list. It will ignore any declarations after, (even if they are also supported). In the current setup IE9, 10 and 11 will download the EOT format even though they all support WOFF. Since WOFF files are already compressed using Gzip compression, developers don't need to worry about enabling compression on the server. If developers forget to enable Gzip compression on the server for EOT files (since we can't provide compressed versions of the EOT files) these users will be downloading 118KB vs 83KB (WOFF). Due to [all the hacks required](https://www.paulirish.com/2009/bulletproof-font-face-implementation-syntax/) to make fonts work properly in older versions of IE there looks to be no way around this. This seems like another good reason to remove the EOT sources from the declaration. Recommended declaration ```css @font-face { font-family: "nta"; src: govuk-font-url("light-68f0c84f0e-v2.woff2") format("woff2"), govuk-font-url("light-222368e53d-v2.woff") format("woff"); font-weight: normal; font-style: normal; font-display: swap; } @font-face { font-family: "nta"; src: govuk-font-url("bold-9561e2d007-v2.woff2") format("woff2"), govuk-font-url("bold-5d3836b441-v2.woff") format("woff"); font-weight: bold; font-style: normal; font-display: swap; } ```

govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1356 May 16, 2019 13:27 Inactive

NickColley reviewed May 16, 2019

View reviewed changes

src/components/button/_button.scss Outdated Show resolved Hide resolved

NickColley reviewed May 16, 2019

View reviewed changes

src/helpers/_font-faces.scss Outdated Show resolved Hide resolved

govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1356 May 17, 2019 06:59 Inactive

govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1356 May 17, 2019 07:29 Inactive

NickColley reviewed May 17, 2019

View reviewed changes

govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1356 May 17, 2019 10:23 Inactive

govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1356 May 20, 2019 07:44 Inactive

Dave House added 12 commits May 21, 2019 16:03

Update package lock

8b9a8f2

Add new fonts and declare in font-faces.scss file

b3e0709

Remove reference to tabular number variable

cb28352

Add CSS for Tabular numbers inside existing mixin

1480c82

Remove button adjustment

6dd4826

Remove tag adjustment

6d7d0b9

Use font display: swap

f98a89a

Add font adjustments in compatibility mode

4af7bad

Update breadcrumb icon position

2c62837

Update back link position

feeaa5d

Update button (roughly)

791a707

Fix header alinment issue

30fc23e

aliuk2012 force-pushed the add-v2-font branch from 7730c8f to 30fc23e Compare May 21, 2019 20:53

govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1356 May 21, 2019 20:53 Inactive

aliuk2012 changed the base branch from master to v3 May 21, 2019 20:53

HACK !!! Can be removed later

c874752

I've added this import for compatibility variables because in the design system there is a method that uses sass-exports to export the _colours palette but fails to run because the compatibility variables cannot be set.

govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1356 May 22, 2019 07:12 Inactive

NickColley added this to the v3.0.0 milestone May 28, 2019

govuk-design-system-ci deployed to govuk-frontend-review-pr-1356 June 5, 2019 10:22 View deployment

aliuk2012 mentioned this pull request Jun 6, 2019

Update font to use v2 of GOV.UK Transport font. #1434

Merged

aliuk2012 mentioned this pull request Jun 10, 2019

Removing font style adjustments #1441

Merged

33 tasks

aliuk2012 closed this Jun 11, 2019

aliuk2012 deleted the add-v2-font branch June 11, 2019 14:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SPIKE - Add v2 font #1356

SPIKE - Add v2 font #1356

dashouse commented May 16, 2019 •

edited

Loading

NickColley May 17, 2019

NickColley May 17, 2019

dashouse May 17, 2019

NickColley May 17, 2019

NickColley May 17, 2019

dashouse commented May 20, 2019 •

edited

Loading

Nooshu commented May 22, 2019 •

edited

Loading

NickColley commented May 22, 2019

aliuk2012 commented Jun 6, 2019

aliuk2012 commented Jun 11, 2019

SPIKE - Add v2 font #1356

SPIKE - Add v2 font #1356

Conversation

dashouse commented May 16, 2019 • edited Loading

Discoveries

NickColley May 17, 2019

Choose a reason for hiding this comment

NickColley May 17, 2019

Choose a reason for hiding this comment

dashouse May 17, 2019

Choose a reason for hiding this comment

NickColley May 17, 2019

Choose a reason for hiding this comment

NickColley May 17, 2019

Choose a reason for hiding this comment

dashouse commented May 20, 2019 • edited Loading

Nooshu commented May 22, 2019 • edited Loading

NickColley commented May 22, 2019

aliuk2012 commented Jun 6, 2019

aliuk2012 commented Jun 11, 2019

dashouse commented May 16, 2019 •

edited

Loading

dashouse commented May 20, 2019 •

edited

Loading

Nooshu commented May 22, 2019 •

edited

Loading