Allow for classes, rowspan, colspan and attributes on row headers #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1367
36degrees
force-pushed
the
table-improvements
branch
from
84060f2 to
cfb673d
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1367
NickColley
approved these changes
May 22, 2019
|
Happy to split the last two commits out into a separate PR if you prefer? |
|
I think it's up to you depending on how confident you are about the new tests. |
36degrees
force-pushed
the
table-improvements
branch
from
cfb673d to
03550eb
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1367
|
👍 I've split that work out and will raise another PR once this has been merged. |
36degrees
force-pushed
the
table-improvements
branch
from
03550eb to
3e3351a
Compare
We used to append a scope="row" to the first table cell in a row, which we did by branching on whether loop.first was true. This was later removed (as scope is only valid on td elements) but the logic was not.
36degrees
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows you to pass classes, rowspan, colspan and attributes to the first cell in each row when
firstCellIsHeaderistrue.It also simplifies the logic of the table template, and tidies up the tests to use a single assertion per test, improve coverage and use a consistent format.(Split into a future PR)Fixes #1261