Fixes the colour of disabled secondary and warning button variants #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix 'Space expected between blocks' linting error
36degrees
approved these changes
May 29, 2019
There was a problem hiding this comment.
Great spot Paul – thanks for fixing this.
Our linter's a bit fussy, so I've taken the liberty of fixing a couple of linting issues for you – I hope that's OK. I've also pushed an extra commit to add examples of disabled secondary and warning buttons that will show up in our review app.
This will need one more review from the team and then we can get this merged for you.
aliuk2012
approved these changes
May 29, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The secondary and warning button variants introduced in v2.12.0 revert to the primary button colour state when disabled.